Skip to content

[browser] Support CoreCLR in WebAssembly SDK#122495

Merged
pavelsavara merged 37 commits intodotnet:mainfrom
maraf:BrowserCoreClrInTree
Dec 19, 2025
Merged

[browser] Support CoreCLR in WebAssembly SDK#122495
pavelsavara merged 37 commits intodotnet:mainfrom
maraf:BrowserCoreClrInTree

Conversation

@maraf
Copy link
Member

@maraf maraf commented Dec 12, 2025 •
edited by pavelsavara
Loading

  • Connect in-tree CoreCLR artifacts with Wasm SDK
  • Disconnect mono native build from Wasm SDK if building for CoreCLR in-tree
  • Define in-tree defaults for CoreCLR
    • WasmEnableWebcil=false
    • InvariantGlobalization=false
    • EnableAggressiveTrimming=false
    • PublishTrimmed=false
  • Prepare an empty shim for CoreCLR native build
  • Copy native (JS, etc) assets to CoreCLR runtime pack
  • Build Wasm SDK packages as part of CoreCLR packages (coreclr-packages.proj)
  • Extend current browser-wasm CoreCLR Debug CI job to produce assets for Wasm.Build.Tests
  • Run Wasm.Build.Tests for CoreCLR with a simple "run main" tests
    • Using plain .NET SDK (dotnet-none) with overrides to use CoreCLR (/p:UseMonoRuntime=false) and points packages to those built from the repository
  • Copy test runners for CoreCLR libtests during build as we don't do nested publish
  • Extend properties pass to nested publish for in-tree sample with /t:RunSample
  • Add .dll if missing to config.mainAssemblyName before running it

Fixes #120647

Some issues discovered when running various tests

  • MainAssemblyName needs to end with .dll
  • Xharness with symbolicator fails
    • XHarness is .NET 9, but we are building plugins as .NET 10. The same problem is with RemoveLoopServer
  • WasmTestRunner is dependent on nested publish AddTestRunnersToPublishedFiles -> ComputeResolvedFilesToPublishList -> WasmTriggerPublishApp
  • Most of with*** function in test-main.js are undefined on CoreCLR - [browser][mono] simplify internal testing switches #122616
  • FileNotFoundException: Could not load file or assembly '/System.Console.Tests.dll'
    • It's Assembly.LoadFrom(TestAssembly). Mono knows "app" assemblies are loaded; CoreCLR requires to load them through VFS
  • Linker tests are missing RuntimeFlavor src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets(241,37): error MSB4057: (NETCORE_ENGINEERING_TELEMETRY=Build) The target "WasmTriggerPublishApp" does not exist in the project.

The runtime pack now contains all the necessary files
image

Errors

Xharness with symbolicator fails 
  [11.0.0-prerelease.25603.1+3df2923500447ee925d59f026c81720c7a9b4e4b] XHarness command issued: wasm test-browser --app=. --output-directory=D:\Development\dotnet\runtime\artifacts\bin\System.Console.Tests\Debug\net11.0\browser-wasm\wwwroot\xharness-output -s dotnet.native.js.symbols --symbol-patterns wasm-symbol-patterns.txt --symbolicator WasmSymbolicator.dll,Microsoft.WebAssembly.Internal.SymbolicatorWrapperForXHarness --browser-path=D:\Development\dotnet\runtime\artifacts\bin\chrome\chrome-win\chrome.exe --timeout=00:30:00 --browser-arg=--js-flags=--stack-trace-limit=1000 --browser-arg=--disable-gpu --pageLoadStrategy=none -- --run WasmTestRunner.dll System.Console.Tests.dll -notrait category=OuterLoop -notrait category=failing
  crit: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
        Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
           at System.Reflection.RuntimeModule.GetDefinedTypes()
           at System.Reflection.RuntimeModule.GetTypes()
           at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 29
           at System.Linq.Enumerable.TryGetFirstNonIterator[TSource](IEnumerable`1 source, Boolean& found)
           at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)
           at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 48
           at Microsoft.DotNet.XHarness.CLI.Commands.XHarnessCommand`1.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/XHarnessCommand.cs:line 145
        System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        File name: 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
        System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        File name: 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
        System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        File name: 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
        System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        File name: 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
        System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
        File name: 'System.Runtime, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
  XHarness exit code: 71 (GENERAL_FAILURE)
  ----- end 2025-12-12 13:48:03.71 ----- exit code 71 ----------------------------------------------------------
  XHarness artifacts: D:\Development\dotnet\runtime\artifacts\bin\System.Console.Tests\Debug\net11.0\browser-wasm\wwwroot\xharness-output
FileNotFoundException: Could not load file or assembly '/System.Console.Tests.dll' ``` dotnet.js:945 DOTNET: FileNotFoundException: Could not load file or assembly '/System.Console.Tests.dll'. The system cannot find the file specified.

at System.Runtime.Loader.AssemblyLoadContext.g____PInvoke|5_0(:63603/IntPtr __ptrNativeAssemblyBinder_native, UInt16* __ilPath_native, UInt16* __niPath_native, ObjectHandleOnStack __retAssembly_native)
at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(:63603/IntPtr ptrNativeAssemblyBinder, String ilPath, String niPath, ObjectHandleOnStack retAssembly)
at System.Runtime.Loader.AssemblyLoadContext.InternalLoadFromPath(:63603/String assemblyPath, String nativeImagePath)
at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(:63603/String assemblyPath)
at System.Reflection.Assembly.LoadFrom(:63603/String assemblyFile)
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.GetTestAssemblies(index.html?arg=--run&arg=WasmTestRunner.dll&arg=System.Console.Tests.dll&arg=-notrait&arg=category%…)
at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationEntryPoint.InternalRunAsync(:63603/LogWriter logger)
at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationEntryPoint.InternalRunAsync(:63603/ApplicationOptions options, TextWriter loggerWriter, TextWriter resultsFile)
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync(index.html?arg=--run&arg=WasmTestRunner.dll&arg=System.Console.Tests.dll&arg=-notrait&arg=category%…)
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run(index.html?arg=--run&arg=WasmTestRunner.dll&arg=System.Console.Tests.dll&arg=-notrait&arg=category%…)
at WasmTestRunner.MainAsync(:63603/String[] args)


</details>

@maraf maraf added this to the 11.0.0 milestone Dec 12, 2025
@maraf maraf self-assigned this Dec 12, 2025
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Dec 12, 2025
This was referenced Dec 12, 2025
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Dec 15, 2025
Open
@build-analysis build-analysis bot mentioned this pull request Dec 17, 2025
Open
3 tasks
pavelsavara
pavelsavara reviewed Dec 18, 2025
View reviewed changes
This was referenced Dec 19, 2025
Open
Open
Open
@pavelsavara pavelsavara mentioned this pull request Dec 19, 2025
Merged
@pavelsavara
Copy link
Member

pavelsavara commented Dec 19, 2025

Wasm.Build.Tests.WasmBrowserRunMainOnly.RunMainOnly 🎉

Log

[log] TestOutput -> Hello from WasmBrowserRunMainOnly!
Exited with 0
[log] WASM EXIT 0

@pavelsavara pavelsavara enabled auto-merge (squash) December 19, 2025 18:52
@pavelsavara pavelsavara mentioned this pull request Dec 19, 2025
Merged
@build-analysis build-analysis bot mentioned this pull request Dec 19, 2025
Open
@pavelsavara
Copy link
Member

pavelsavara commented Dec 19, 2025

/ba-g known issues
#113686
#112360
#122669
#122671

@pavelsavara pavelsavara merged commit 637d4b5 into dotnet:main Dec 19, 2025
170 of 177 checks passed
This was referenced Dec 19, 2025
Open
Open
@jkotas jkotas mentioned this pull request Dec 19, 2025
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Jan 9, 2026
Closed
@maraf maraf deleted the BrowserCoreClrInTree branch January 12, 2026 09:24
@dotnet-maestro dotnet-maestro bot mentioned this pull request Jan 14, 2026
Merged
@maraf maraf mentioned this pull request Jan 14, 2026
Merged
@lewing lewing mentioned this pull request Jan 21, 2026
Merged
@hez2010 hez2010 mentioned this pull request Feb 9, 2026
Merged
@lewing lewing mentioned this pull request Feb 11, 2026
Open
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

[wasm][coreclr] Bring WBT tests on coreclr, make a few non-workload WBT tests work

2 participants

@maraf @pavelsavara